search

kubesphere / devops-agent

Agents for Kubesphere DevOps
Apache License 2.0
61 stars 73 forks source link

Yum resources not cleaned up manually after Podman installation in base/podman/Dockerfile #62

Closed JohnNiang closed 2 years ago

JohnNiang commented 2 years ago

Please see the Podman installation: https://github.com/kubesphere/devops-agent/blob/45621490aa967122acaba25da6ef6c603ce75f5c/base/podman/Dockerfile#L60-L62

After the installation, yum resources were not cleaned up.

/kind enhancement

ks-ci-bot commented 2 years ago

@JohnNiang: The label(s) kind/enhancement cannot be applied, because the repository doesn't have them.

In response to [this](https://github.com/kubesphere/devops-agent/issues/62): >Please see the Podman installation: >https://github.com/kubesphere/devops-agent/blob/45621490aa967122acaba25da6ef6c603ce75f5c/base/podman/Dockerfile#L60-L62 > >After the installation, yum resources were not cleaned up. > >/kind enhancement Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
JohnNiang commented 2 years ago

/priority high

JohnNiang commented 2 years ago

I could confirm that the size of the last docker image will be decreased, please see the screenshot below:

image

JohnNiang commented 2 years ago

Dive into docker image:

image

image

JohnNiang commented 2 years ago

I suggest putting Podman installation into https://github.com/kubesphere/devops-agent/blob/45621490aa967122acaba25da6ef6c603ce75f5c/base/podman/Dockerfile#L4

to reduce layer generation and total size of the docker image.

/kind optimization /good-first-issue

ks-ci-bot commented 2 years ago

@JohnNiang: This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to [this](https://github.com/kubesphere/devops-agent/issues/62): >I suggest putting Podman installation into >https://github.com/kubesphere/devops-agent/blob/45621490aa967122acaba25da6ef6c603ce75f5c/base/podman/Dockerfile#L4 > >to reduce layer generation and total size of the docker image. > >/kind optimization >/good-first-issue Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
LinuxSuRen commented 2 years ago

hi @JohnNiang , thanks for reporting this issue. But IMO this might not be a high-priority issue. Especially you already putted a good-first-issue label for it.

123liubao commented 2 years ago

/assign