search

kubesphere / ks-devops

This is a cloud-native application that focuses on the DevOps area.
https://kubesphere.io/devops/
Apache License 2.0
159 stars 89 forks source link

Fix shell validate failed #1001

Closed chilianyi closed 1 year ago

chilianyi commented 1 year ago

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Please check the following list before waiting reviewers:

Does this PR introduce a user-facing change??

Fix shell validate error

fix #1000

chilianyi commented 1 year ago

/cherry-pick release-3.4 /cherry-pick release-3.5

ks-ci-bot commented 1 year ago

@chilianyi: once the present PR merges, I will cherry-pick it on top of release-3.4 in a new PR and assign it to you.

In response to [this](https://github.com/kubesphere/ks-devops/pull/1001#issuecomment-1756894930): >/cherry-pick release-3.4 >/cherry-pick release-3.5 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
yudong2015 commented 1 year ago

/lgtm /approve

ks-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yudong2015

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubesphere/ks-devops/blob/master/OWNERS)~~ [yudong2015] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ks-ci-bot commented 1 year ago

@chilianyi: new pull request created: #1002

In response to [this](https://github.com/kubesphere/ks-devops/pull/1001#issuecomment-1756894930): >/cherry-pick release-3.4 >/cherry-pick release-3.5 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
ks-ci-bot commented 1 year ago

@chilianyi: new pull request created: #1003

In response to [this](https://github.com/kubesphere/ks-devops/pull/1001#issuecomment-1756894930): >/cherry-pick release-3.4 >/cherry-pick release-3.5 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.