search

kubesphere / ks-installer

Install KubeSphere on existing Kubernetes cluster
https://kubesphere.io
Apache License 2.0
532 stars 747 forks source link

Refactoring the code of Controller #2266

Closed mohamed-rafraf closed 9 months ago

mohamed-rafraf commented 9 months ago 
This PR refactors a previously monolithic script into splitted components

Aiming to enhance code maintainability, facilitate easier debugging, and support scalable development. By breaking down the code into focused modules, enabling more straightforward updates, collaborative development

In Order to test the new controller. Build docker image from Dockerfile.complete file!

mohamed-rafraf commented 9 months ago

/assign @benjaminhuo

benjaminhuo commented 9 months ago

Thanks @mohamed-rafraf cc @pixiake

pixiake commented 9 months ago

@mohamed-rafraf That's Great ! Thnaks

If possible, you can change the Dockerfile in the ci configuration file to Dockerfile.complete. https://github.com/kubesphere/ks-installer/blob/ef79beead3285698cdce559dd5505c79fe11dbff/.github/workflows/e2e-TEST.yml#L38

mohamed-rafraf commented 9 months ago

@pixiake Thank you! It's changed!

pixiake commented 9 months ago

/lgtm /approve

ks-ci-bot commented 9 months ago

LGTM label has been added.

Git tree hash: f34b3dd2b30107e89806d488bf2b8b7a4ac55489

ks-ci-bot commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mohamed-rafraf, pixiake

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubesphere/ks-installer/blob/master/OWNERS)~~ [pixiake] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment