search

kubesphere / kubeeye

KubeEye aims to find various problems on Kubernetes, such as application misconfiguration, unhealthy cluster components and node problems.
https://kubesphere.io
Apache License 2.0
810 stars 126 forks source link

Fix: check for nil LastScheduleTime #295

Closed dkeven closed 1 year ago

dkeven commented 1 year ago

What type of PR is this?

What this PR does / Why we need it:

Check for nil AuditPlan.Status.LastScheduleTime to avoid a wrong trigger of AuditTask every time an AuditPlan is synced for the first time.

dkeven commented 1 year ago

/cc @pixiake @stoneshi-yunify

ks-ci-bot commented 1 year ago

@dkeven: GitHub didn't allow me to request PR reviews from the following users: stoneshi-yunify.

Note that only kubesphere members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to [this](https://github.com/kubesphere/kubeeye/pull/295#issuecomment-1547535962): >/cc @pixiake @stoneshi-yunify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
pixiake commented 1 year ago

/lgtm /approve

ks-ci-bot commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkeven, pixiake, stoneshi-yunify

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubesphere/kubeeye/blob/experiment/OWNERS)~~ [pixiake] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment