kubesphere / kubekey

Install Kubernetes/K3s only, both Kubernetes/K3s and KubeSphere, and related cloud-native add-ons, it supports all-in-one, multi-node, and HA 🔥 ⎈ 🐳
https://kubesphere.io
Apache License 2.0
2.18k stars 518 forks source link

feature/support image transport argument to allow export images from and to docker daemon #2255

Closed will4j closed 1 month ago

will4j commented 1 month ago

What type of PR is this?

/kind feature

What this PR does / why we need it:

Support export images to oci dir from local docker-daemon (default from remote registry). Support push images from oci dir directly to docker-daemon, skip local registry.

usecase:

# export from docker-daemon
kk artifact export --skip-remove-artifact --image-transport docker-daemon -m manifests.yaml -o kubesphere.tar.gz
# push to docker-daemon
kk artifact images push --image-transport docker-daemon -f cluster.yaml -a kubesphere.tar.gz

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Does this PR introduced a user-facing change?

Support export images from and push back to docker-daemon.

Additional documentation, usage docs, etc.:

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

will4j commented 1 month ago

/assign @pixiake

pixiake commented 1 month ago

@will4j Thanks for this contributions ! /lgtm /approve

ks-ci-bot commented 1 month ago

LGTM label has been added.

Git tree hash: 6ee3a582caa21a30c17a96be76ed60035bcec0c2

ks-ci-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pixiake, will4j

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubesphere/kubekey/blob/master/OWNERS)~~ [pixiake] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment