fix some bug when using playbook

kubesphere / kubekey

Install Kubernetes/K3s only, both Kubernetes/K3s and KubeSphere, and related cloud-native add-ons, it supports all-in-one, multi-node, and HA 🔥 ⎈ 🐳

https://kubesphere.io

Apache License 2.0

2.38k stars 554 forks source link

fix some bug when using playbook #2427

Closed dbbDylan closed 1 month ago

dbbDylan commented 1 month ago

What type of PR is this?

/kind bug

What this PR does / why we need it:

fix the src path ends with \n in some conditions when using the copy playbook module.
fix tags that don't work with playbook.roles.

Does this PR introduced a user-facing change?

- fix the src path ends with `\n` in some conditions when using the `copy` playbook module.
- fix tags that don't work with `playbook.roles`.

sonarcloud[bot] commented 1 month ago

Quality Gate failed

Failed conditions
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

kubesphere-prow[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: dbbDylan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubesphere/kubekey/blob/feature-gitops/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment