kubestellar / kubeflex

A flexible and scalable platform for running Kubernetes control plane APIs.
Apache License 2.0
48 stars 13 forks source link

bug: update-cluster-info job refers to `latest` tag of cmupdate #275

Open MikeSpreitzer opened 3 months ago

MikeSpreitzer commented 3 months ago

Describe the bug

The update-cluster-info Job invariably references the cmupdate image using the tag "latest". This is problematic, it does not allow bakward-incompatible changes in the future.

https://github.com/kubestellar/kubeflex/blob/v0.6.2/pkg/reconcilers/shared/job.go#L128-L131 is prepared to be asked for a specific version, but never is: the value of "version" originates in the Version field of the struct type BaseReconciler, and nothing ever assigns to that field.

Steps To Reproduce

See above.

Expected Behavior

Our future hands are not tied.

Additional Context

No response