Closed Adesoji1 closed 4 months ago
We are not accepting the changes until specifically targeted towards an issue raised by the community. Kindly work towards resolving an issue, if the admins approve it, you can contribute to it.
Thank you
On Tue, 25 June 2024, 1:41 am Abhijeet Mazumdar, @.***> wrote:
We are not accepting the changes until specifically targeted towards an issue raised by the community. Kindly work towards resolving an issue, if the admins approve it, you can contribute to it.
— Reply to this email directly, view it on GitHub https://github.com/kubetoolsca/krs/pull/26#issuecomment-2187694778, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE4COXFRZS6QMTEGSBDPU4TZJC4EHAVCNFSM6AAAAABJZ3WCQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOBXGY4TINZXHA . You are receiving this because you authored the thread.Message ID: @.***>
@ajeetraina @karanveersingh5623
Pull Request Title
Pull Request Description
Summary
This PR introduces several enhancements and fixes to the Kubernetes Recommendation Service (KRS). The main changes include adding GPU support for LLM models, refactoring the CLI commands, more readability, and ensuring proper dependency management.
Changes
GPU Support for LLM Models:
llm_client.py
to support GPU utilization for Hugging Face models.KrsMain
class inmain.py
to pass the device option (CPU/GPU) toKrsGPTClient
.CLI Enhancements:
krs.py
to use Typer for CLI command definitions.version
command to display the current version of KRS.Dependency Management:
requirements.sh
andrequirements.bat
for installing dependencies on Linux/macOS and Windows, respectively.setup.py
to conditionally execute the appropriate script based on the operating system.Initialization and Health Check:
init
) and health check (health
) commands to handle configuration more robustly.Bug Fixes and Improvements:
Modified Files
krs/utils/llm_client.py
: i Added GPU support for Hugging Face models.krs/main.py
: i Updated to handle GPU device option and refactored health check logic.krs/krs.py
: i Refactored CLI commands using Typer, addedversion
command.krs/utils/cluster_scanner.py
:i Enhanced logging for kubeconfig loading.krs/utils/fetch_tools_krs.py
: Fixed issues with GitHub stars conversion.krs/utils/constants.py
: No significant changes required.setup.py
: Updated to include dependency scripts execution based on OS.requirements.sh
: Shell script for installing dependencies on Linux/macOS.requirements.bat
: Batch script for installing dependencies on Windows.printdependency.py
: i Added script to print PyTorch and CUDA versions. -test-cluster_scanner.py
: i created a pytest script for thisAdditional Information
Notes
Screenshots
i added a folder of screenshots
we need to Fix warnings related to GitHub stars conversion in
fetch_tools_krs.py
. Please review the changes and provide feedback because i don't have a kubeconfig file so i can't test the gpu yet. Let me know if any further modifications or clarifications are needed. i used python version 3.11 on ubuntu 22.03