Redundant Recommendation

[ronaldpetty]

This might be incorrect, but probably worth looking into. I have been doing K8sGPT development and have it installed (as an operator). It appears to find it but still recommends it. I will work on this to confirm its not just my setup. Even so, probably worth a simple reconciliation step before presenting what was found and what is recommended.

% krs recommend

Scanning your cluster...

ERROR:root:Failed to fetch logs for container broken in pod broken: (400)
Reason: Bad Request
HTTP response headers: HTTPHeaderDict({'Audit-Id': 'f2f45496-39af-4dbd-bf77-c0d78b14f444', 'Cache-Control': 'no-cache, private', 'Content-Type': 'application/json', 'Date': 'Sun, 28 Jul 2024 04:23:09 GMT', 'Content-Length': '207'})
HTTP response body: {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"container \"broken\" in pod \"broken\" is waiting to start: trying and failing to pull image","reason":"BadRequest","code":400}

Cluster scanned successfully...

Extracted tools used in cluster...

The cluster is using the following tools:

+-------------+--------+-------------------------+---------------+
| Tool Name   |   Rank | Category                | CNCF Status   |
+=============+========+=========================+===============+
| kyverno     |     38 | Security Tools          | listed        |
+-------------+--------+-------------------------+---------------+
|             |     14 | Testing Tools           | listed        |
+-------------+--------+-------------------------+---------------+
| k8sgpt      |      1 | Artificial Intelligence | sandbox       |
+-------------+--------+-------------------------+---------------+

Our recommended tools for this deployment are:

+-------------------------+------------------------+-------------+---------------+
| Category                | Recommendation         | Tool Name   | CNCF Status   |
+=========================+========================+=============+===============+
| Security Tools          | Recommended tool       | trivy       | listed        |
+-------------------------+------------------------+-------------+---------------+
| Testing Tools           | Recommended tool       | k6d         | unlisted      |
+-------------------------+------------------------+-------------+---------------+
| Artificial Intelligence | Already using the best | k8sgpt      | sandbox       |
+-------------------------+------------------------+-------------+---------------+

[ronaldpetty]

I also noticed the empty tool on the found list. Not sure if its related or not but didn't submit a different ticket for it (yet).

[karanveersingh5623]

@ronaldpetty , it shows the rank 1 tool in recommendation but it says , that you are already using the best , let me know if this answers you question or any rank 1 tools which are scanned in previous steps should be removed ? Because we are not recommending as you can see the text along with it

[karanveersingh5623]

I also noticed the empty tool on the found list. Not sure if its related or not but didn't submit a different ticket for it (yet).

@ronaldpetty , can you raise another issue for this

[ronaldpetty]

@karanveersingh5623 I'm sorry, I misread the second section. I'll close and open a new ticket.