search

kubev2v / forklift-console-plugin

OpenShift Console Plugin For Forklift, the plugin adds a web based user interface for Migration Toolkit for Virtualization inside Openshift web console.
Apache License 2.0
3 stars 15 forks source link

:lady_beetle: [UI] max_vm_inflight parameter is not setting #1267

Closed duduvaa closed 1 month ago

duduvaa commented 1 month ago

While trying to change 'max_vm_inflight' parameter from the UI, nothing happens.

The forklift-controller pod isn't restarted and 'MAX_VM_INFLIGHT' doesn't exist in 'oc describe pod forklift-controller-xxxxx'.

The issue is that the parameter is set as a string and not as a number.

workaround: Change the value from 'MTV operator' --> 'All instances' --> ForkliftControoler --> YAML --> spec --> controller_max_vm_inflight

yaacov commented 1 month ago

some config items are tested using is number see: https://github.com/kubev2v/forklift/blob/611fee69bedf00d2eece9b41630a99f35441ee1e/operator/roles/forkliftcontroller/templates/controller/deployment-controller.yml.j2#L84

in backend checking for is number: controller_log_level controller_precopy_interval controller_vddk_job_active_deadline_sec controller_snapshot_removal_timeout_minuts controller_snapshot_status_check_rate_seconds controller_snapshot_status_check_rate_seconds controller_max_vm_inflight controller_cdi_export_token_ttl controller_filesystem_overhead

set in the UI:

controller_max_vm_inflight controller_precopy_interval controller_snapshot_status_check_rate_seconds

yaacov commented 1 month ago

addressed by https://github.com/kubev2v/forklift-console-plugin/pull/1268