search

kubev2v / forklift-console-plugin

OpenShift Console Plugin For Forklift, the plugin adds a web based user interface for Migration Toolkit for Virtualization inside Openshift web console.
Apache License 2.0
3 stars 15 forks source link

:lady_beetle: plan status "vm fail" should be "partial fail" #1277

Open yaacov opened 1 month ago

yaacov commented 1 month ago

Issue: when one of more vms fails, we show status "vm fail" it's more helpful to call this status "partial"

sgratch commented 2 days ago

There are 2 suggestions for the replaced migration status of this state where part of the VMs already failed but the plan migration is still not marked as failed:

option 1: a hard-coded "Some VMs Failed" status - suggested by @RichardHoch option 2: a dynamic "X VMs failed" while X=num of current failed VMs status - suggested by @tashkena option 3: a hard-coded "Partial Failed" status. Not very clear what is partial and why.

Screenshots:

Before: Screenshot from 2024-09-05 14-18-52

After - option 1: Screenshot from 2024-09-05 15-48-08

After - option 2: Screenshot from 2024-09-05 16-41-21

@yaacov WDYT?

sgratch commented 2 days ago

Current PR supports option 1