search

kubev2v / forklift-operator

This repository has been archived, development moved to https://github.com/kubev2v/forklift
Apache License 2.0
19 stars 19 forks source link

Re-enable UI when running on k8s #155

Closed fbladilo closed 3 years ago

fbladilo commented 3 years ago

Remove force-disablement of UI on k8s clusters as work on this will be starting during this Forklift release.

ghost commented 3 years ago

Why not wait until we have a solution in place for the UI authentication? Until then, re-enabling the UI will make the deployment fail.

fbladilo commented 3 years ago

@fdupont-redhat the deployment of UI actually succeeds , the issue is that UI does not know yet how to handle the absence of oauth2 , we can wait or just have it available for UI devs so they can successfully begin their testing with latest operator.

ghost commented 3 years ago

But they can already enable the UI with feature_ui: true, no?

fbladilo commented 3 years ago

@fdupont-redhat They can set feature_ui: true and will take precedence but the controlling variable in that conditional is k8s_cluster meaning that only gets processed on OpenShift and not k8s , they will have to force that variable too but will have unintended consequences.