kubev2v / forklift-operator

This repository has been archived, development moved to https://github.com/kubev2v/forklift
Apache License 2.0
19 stars 19 forks source link

Bug 2026702: Do not override controller and validation service configmaps #193

Closed fabiendupont closed 2 years ago

fabiendupont commented 2 years ago

We have seen cases where the validation service configmap data was emptied. We suspect that the operator role overrides the data. According to the k8s module documentation, a strategic merge is done and it should retain the files listed in .data. Observation in the field is different.

This pull request checks the presence of the controller and validation service configmaps and skips the configmap creation/update if it exists. This should avoid any risk of the operator overriding them when they contain user data.

Signed-off-by: Fabien Dupont fabiendupont@pm.me

github-actions[bot] commented 2 years ago

Valid bug 2026702