kubevela / velaux

The KubeVela User Experience (UX) Platform
Apache License 2.0
138 stars 111 forks source link

Fix: fail to get global helm config secret #867

Closed chivalryq closed 1 year ago

chivalryq commented 1 year ago

Signed-off-by: Qiaozp qiaozhongpei.qzp@alibaba-inc.com

Description of your changes

The logic in GetConfig interface will return extract auth info from secret error when the configured helm repo is from global config.

image

Fixes #

I have:

Special notes for your reviewer

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 83.87% and project coverage change: -0.66% :warning:

Comparison is base (3978079) 59.05% compared to head (96e3596) 58.39%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #867 +/- ## ========================================== - Coverage 59.05% 58.39% -0.66% ========================================== Files 114 115 +1 Lines 19795 20039 +244 ========================================== + Hits 11690 11702 +12 - Misses 6674 6901 +227 - Partials 1431 1436 +5 ``` | Flag | Coverage Δ | | |---|---|---| | apiserver-unittests | `31.87% <67.74%> (-0.30%)` | :arrow_down: | | server-e2e-tests | `47.81% <58.06%> (-0.67%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubevela#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/kubevela/velaux/pull/867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubevela) | Coverage Δ | | |---|---|---| | [pkg/server/domain/service/helm.go](https://app.codecov.io/gh/kubevela/velaux/pull/867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubevela#diff-cGtnL3NlcnZlci9kb21haW4vc2VydmljZS9oZWxtLmdv) | `49.60% <66.66%> (+0.39%)` | :arrow_up: | | [pkg/server/domain/service/config.go](https://app.codecov.io/gh/kubevela/velaux/pull/867?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubevela#diff-cGtnL3NlcnZlci9kb21haW4vc2VydmljZS9jb25maWcuZ28=) | `64.06% <85.71%> (+1.66%)` | :arrow_up: | ... and [13 files with indirect coverage changes](https://app.codecov.io/gh/kubevela/velaux/pull/867/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=kubevela)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.