search

kubevirt-ui / kubevirt-plugin

Kubevirt plugin for Openshift Console
Apache License 2.0
14 stars 29 forks source link

[release-4.15] CNV-42852: manual backporting os label fix to 4.15 #2122

Closed metalice closed 2 months ago

metalice commented 2 months ago

📝 Description

Manual backport of os label fix to 4.15 If no os detected, don't use fedora as user name for clud init, use user name "cloud-user"

🎥 Demo

Please add a video or an image of the behavior/changes

openshift-ci-robot commented 2 months ago

@metalice: This pull request references CNV-42852 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.z" version, but no target version was set.

In response to [this](https://github.com/kubevirt-ui/kubevirt-plugin/pull/2122): > > >## 📝 Description > >Manual backport of os label fix to 4.15 >If no os detected, don't use fedora as user name for clud init, use user name "cloud-user" >## 🎥 Demo > >> Please add a video or an image of the behavior/changes > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=kubevirt-ui%2Fkubevirt-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt-ui/kubevirt-plugin/blob/release-4.15/OWNERS)~~ [avivtur,metalice] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment