search

kubevirt-ui / kubevirt-plugin

Kubevirt plugin for Openshift Console
Apache License 2.0
12 stars 24 forks source link

CNV-45584: Update Edit CPU | Memory modal UI #2131

Closed pcbailey closed 3 weeks ago

pcbailey commented 1 month ago

📝 Description

This PR updates the design of the CPU/memory modal to give the user two methods for configuring the CPU: enter the CPU topology manually and entering the number of desired vCPUs.

Jira: https://issues.redhat.com/browse/CNV-45584

🎥 Screenshots

Before

cpu-mem-redesign--BEFORE--2024-08-16_22-24

After

cpu-mem-redesign--AFTER--2024-08-16_21-06

openshift-ci-robot commented 1 month ago

@pcbailey: This pull request references CNV-45584 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/kubevirt-ui/kubevirt-plugin/pull/2131): >## 📝 Description > >This PR updates the design of the CPU/memory modal to give the user two methods for configuring the CPU: enter the CPU topology manually and entering the number of desired vCPUs. > >Jira: https://issues.redhat.com/browse/CNV-45584 > >## 🎥 Demo > > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=kubevirt-ui%2Fkubevirt-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@pcbailey: This pull request references CNV-45584 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/kubevirt-ui/kubevirt-plugin/pull/2131): >## 📝 Description > >This PR updates the design of the CPU/memory modal to give the user two methods for configuring the CPU: enter the CPU topology manually and entering the number of desired vCPUs. > >Jira: https://issues.redhat.com/browse/CNV-45584 > >## 🎥 Screenshots > >### Before > >![cpu-mem-redesign--BEFORE--2024-08-16_22-24](https://github.com/user-attachments/assets/daf56188-30da-49bd-8e08-7ce97bf41e5b) > >### After > >![cpu-mem-redesign--AFTER--2024-08-16_21-06](https://github.com/user-attachments/assets/3fafa577-77d9-4545-8c23-b2e9a014f58b) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=kubevirt-ui%2Fkubevirt-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
pcbailey commented 1 month ago

/retest

pcbailey commented 1 month ago

/retest

avivtur commented 3 weeks ago

/lgtm /retest

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt-ui/kubevirt-plugin/blob/main/OWNERS)~~ [avivtur,pcbailey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment