kubevirt-ui / kubevirt-plugin

Kubevirt plugin for Openshift Console
Apache License 2.0
14 stars 29 forks source link

CNV-46589: Auto-generate meaningful snapshot names #2142

Closed pcbailey closed 2 months ago

pcbailey commented 2 months ago

📝 Description

Previously, auto-generated snapshot names provided no useful information outside of the VM name. This PR modifies the name format to add creation date and time information to make the auto-generated names more meaningful.

Jira: https://issues.redhat.com/browse/CNV-46589

🎥 Screenshots

Before

generate-snapshot-name--BEFORE--2024-08-21_09-08

After

generate-snapshot-name--AFTER--2024-08-21_09-03

openshift-ci-robot commented 2 months ago

@pcbailey: This pull request references CNV-46589 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.18.0" version, but no target version was set.

In response to [this](https://github.com/kubevirt-ui/kubevirt-plugin/pull/2142): >## 📝 Description > >Previously, auto-generated snapshot names provided no useful information outside of the VM name. This PR modifies the name format to add creation date and time information to make the auto-generated names more meaningful. > >Jira: https://issues.redhat.com/browse/CNV-46589 > >## 🎥 Screenshots > >### Before > >![generate-snapshot-name--BEFORE--2024-08-21_09-08](https://github.com/user-attachments/assets/f813492a-8026-4420-9afe-e176b74871c8) > >### After > >![generate-snapshot-name--AFTER--2024-08-21_09-03](https://github.com/user-attachments/assets/73bdc7cd-e6be-472a-885b-6d98c8e9b2ca) Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=kubevirt-ui%2Fkubevirt-plugin). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, metalice, pcbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt-ui/kubevirt-plugin/blob/main/OWNERS)~~ [avivtur,metalice,pcbailey] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
metalice commented 2 months ago

/retest