kubevirt-bot
commented
2 years ago [APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: mfranczy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
- ~~[OWNERS](https://github.com/kubevirt/cloud-provider-kubevirt/blob/main/OWNERS)~~ [mfranczy]
Approvers can indicate their approval by writing `/approve` in a comment
Approvers can cancel approval by writing `/approve cancel` in a comment
Sometimes the kubeconfig secret does not need to be generated depending on on the consumer (capk has the secret already created [1]). This change move the overlay common parts to different bases so the final overlay can decide at the bases if they want a secret or not.
[1] https://github.com/kubernetes-sigs/cluster-api-provider-kubevirt/pull/168