search

kubevirt / cloud-provider-kubevirt

Kubernetes cloud-provider for KubeVirt
Apache License 2.0
73 stars 34 forks source link

Intoduce endpointslice controller #330

Closed kvaps closed 6 days ago

kvaps commented 2 months ago

Based on https://github.com/kubevirt/cloud-provider-kubevirt/pull/291 Vendor dependencies https://github.com/kubevirt/cloud-provider-kubevirt/pull/331 Fixes https://github.com/kubevirt/cloud-provider-kubevirt/issues/41

kvaps commented 2 months ago

/assign @qinqon

kvaps commented 2 months ago

How can I make tests passed if you need to separate PRs for vendor upgades and feature itself?

brianmcarey commented 1 month ago

How can I make tests passed if you need to separate PRs for vendor upgades and feature itself?

The e2e tests were failing due to a short container image name being used - the lane should be good after https://github.com/kubevirt/cloud-provider-kubevirt/pull/332

qinqon commented 1 month ago

/retest

kvaps commented 1 month ago

@qinqon this pr will not work without https://github.com/kubevirt/cloud-provider-kubevirt/pull/331 get merged

qinqon commented 1 month ago

@qinqon this pr will not work without #331 get merged

merged /retest

kvaps commented 1 month ago

PR rebased

qinqon commented 1 month ago

@kvaps are all the comments at https://github.com/kubevirt/cloud-provider-kubevirt/pull/291 addressed ?

kvaps commented 2 weeks ago

@qinqon yes

qinqon commented 6 days ago

/lgtm /approve

kubevirt-bot commented 6 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/cloud-provider-kubevirt/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment