search

kubevirt / cloud-provider-kubevirt

Kubernetes cloud-provider for KubeVirt
Apache License 2.0
73 stars 34 forks source link

Update vendor dependencies for endpointslice controller #331

Closed kvaps closed 1 month ago

kvaps commented 2 months ago

required for https://github.com/kubevirt/cloud-provider-kubevirt/pull/331

go get 'k8s.io/endpointslice/util@v0.28' 'k8s.io/apiserver@v0.28' 'k8s.io/cloud-provider@v0.28'
go mod tidy
go mod vendor

Signed-off-by: Andrei Kvapil kvapss@gmail.com

kvaps commented 2 months ago

/assign @qinqon

qinqon commented 2 months ago

/retest

kvaps commented 2 months ago

I don't know why test is failing, locally it is built ok:

[+] Building 6.2s (15/15) FINISHED                                                                                                                                               docker:amd64
 => [internal] load build definition from Dockerfile                                                                                                                                     0.9s
 => => transferring dockerfile: 605B                                                                                                                                                     0.1s
 => [internal] load metadata for registry.access.redhat.com/ubi9/ubi-micro:latest                                                                                                        0.7s
 => [internal] load metadata for docker.io/library/golang:1.20.6                                                                                                                         1.6s
 => [internal] load .dockerignore                                                                                                                                                        0.3s
 => => transferring context: 2B                                                                                                                                                          0.1s
 => [stage-1 1/2] FROM registry.access.redhat.com/ubi9/ubi-micro:latest@sha256:7f376b75faf8ea546f28f8529c37d24adcde33dca4103f4897ae19a43d58192b                                          0.0s
 => [builder 1/7] FROM docker.io/library/golang:1.20.6@sha256:010a0ffe47398a3646993df44906c065c526eabf309d01fb0cbc9a5696024a60                                                           0.0s
 => [internal] load build context                                                                                                                                                        1.3s
 => => transferring context: 591.91kB                                                                                                                                                    1.0s
 => CACHED [builder 2/7] WORKDIR /go/src/kubevirt.io/cloud-provider-kubevirt                                                                                                             0.0s
 => CACHED [builder 3/7] COPY go.* ./                                                                                                                                                    0.0s
 => CACHED [builder 4/7] COPY pkg/ pkg/                                                                                                                                                  0.0s
 => CACHED [builder 5/7] COPY cmd/ cmd/                                                                                                                                                  0.0s
 => CACHED [builder 6/7] COPY vendor/ vendor/                                                                                                                                            0.0s
 => CACHED [builder 7/7] RUN CGO_ENABLED=0 GOOS=linux go build -mod=vendor -ldflags="-s -w" -o bin/kubevirt-cloud-controller-manager ./cmd/kubevirt-cloud-controller-manager             0.0s
 => CACHED [stage-1 2/2] COPY --from=builder /go/src/kubevirt.io/cloud-provider-kubevirt/bin/kubevirt-cloud-controller-manager /bin/kubevirt-cloud-controller-manager                    0.0s
 => exporting to image                                                                                                                                                                   0.3s
 => => exporting layers                                                                                                                                                                  0.0s
 => => writing image sha256:81be6df64c5480450a78eb7c9dd095ff4073b18d88325aa24ffc3992ee5cc52a                                                                                             0.1s
 => => naming to 127.0.0.1:40349/kubevirt-cloud-controller-manager:main                                                                                                                  0.1s

 1 warning found (use --debug to expand):
 - FromPlatformFlagConstDisallowed: FROM --platform flag should not use constant value "linux/amd64" (line 1)
kvaps commented 2 months ago

/test pull-kubevirt-cloud-provider-kubevirt-e2e

qinqon commented 1 month ago

/lgtm /approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/cloud-provider-kubevirt/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kvaps commented 1 month ago

/test pull-kubevirt-cloud-provider-kubevirt-e2e

qinqon commented 1 month ago

/retest

Issue was fixed.