kubevirt / cloud-provider-kubevirt

Kubernetes cloud-provider for KubeVirt
Apache License 2.0
73 stars 34 forks source link

Use full image name for golang builder container image #332

Closed brianmcarey closed 1 month ago

brianmcarey commented 1 month ago

What this PR does / why we need it:

The podman instance in CI no longer accepts short images names.

Update the kubevirt-cloud-controller-manager Containerfile to use the full name for the golang builder image.

This allows the e2e lane to pass again[1]

[1] https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_cloud-provider-kubevirt/332/pull-kubevirt-cloud-provider-kubevirt-e2e/1841490243212021760

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

kubevirt-bot commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

brianmcarey commented 1 month ago

/test pull-kubevirt-cloud-provider-kubevirt-e2e

qinqon commented 1 month ago

/lgtm /approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qinqon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/cloud-provider-kubevirt/blob/main/OWNERS)~~ [qinqon] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment