search

kubevirt / common-instancetypes

Instancetypes and preferences for running VMs on KubeVirt
https://kubevirt.io/user-guide/virtual_machines/instancetypes/#common-instancetypes
Apache License 2.0
22 stars 15 forks source link

preferences: Set vm.kubevirt.io/os within eventual VMI #203

Closed lyarwood closed 2 months ago

lyarwood commented 2 months ago

/cc @0xFelix /cherry-pick release-1.0

What this PR does / why we need it:

This annotation while not defined in the KubeVirt API reference is used by downstream consumers, most notably the OpenShift Console. This commit brings us in line with common-templates where this annotation is set on the VirtualMachine.

https://github.com/kubevirt/common-templates/blob/c0e482da8195f2fd45a0e19d8a4ee17f66a1d4f7/templates/windows10.tpl.yaml#L97

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

`vm.kubevirt.io/os` is now set as an annotation on resulting `VirtualMachineInstances` using preferences provided by the common-instancetypes project
kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-instancetypes/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lyarwood commented 2 months ago

/cherry-pick release-1.0

kubevirt-bot commented 2 months ago

@lyarwood: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to [this](https://github.com/kubevirt/common-instancetypes/pull/203#issuecomment-2228189214): >/cherry-pick release-1.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 months ago

@lyarwood: new pull request created: #204

In response to [this](https://github.com/kubevirt/common-instancetypes/pull/203#issuecomment-2228189214): >/cherry-pick release-1.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.