search

kubevirt / common-instancetypes

Instancetypes and preferences for running VMs on KubeVirt
https://kubevirt.io/user-guide/virtual_machines/instancetypes/#common-instancetypes
Apache License 2.0
22 stars 15 forks source link

tests: Add VirtualMachine output on failure #206

Closed lyarwood closed 2 months ago

lyarwood commented 2 months ago

/cc @0xFelix

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-instancetypes/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
lyarwood commented 2 months ago

/cherry-pick release-1.0 /cherry-pick release-0.4

kubevirt-bot commented 2 months ago

@lyarwood: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

In response to [this](https://github.com/kubevirt/common-instancetypes/pull/206#issuecomment-2228515656): >/cherry-pick release-1.0 >/cherry-pick release-0.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 months ago

@lyarwood: you cannot LGTM your own PR.

In response to [this](https://github.com/kubevirt/common-instancetypes/pull/206#issuecomment-2228576309): >/lgtm > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akrejcir commented 2 months ago

/lgtm

kubevirt-bot commented 2 months ago

@lyarwood: new pull request created: #207

In response to [this](https://github.com/kubevirt/common-instancetypes/pull/206#issuecomment-2228515656): >/cherry-pick release-1.0 >/cherry-pick release-0.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 2 months ago

@lyarwood: new pull request created: #208

In response to [this](https://github.com/kubevirt/common-instancetypes/pull/206#issuecomment-2228515656): >/cherry-pick release-1.0 >/cherry-pick release-0.4 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.