search

kubevirt / common-instancetypes

Instancetypes and preferences for running VMs on KubeVirt
https://kubevirt.io/user-guide/virtual_machines/instancetypes/#common-instancetypes
Apache License 2.0
22 stars 15 forks source link

Remove Windows 2k12 template #213

Closed fossedihelm closed 1 month ago

fossedihelm commented 1 month ago

What this PR does / why we need it: Remove Windows 2k12 template

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): jira: https://issues.redhat.com/browse/CNV-41784

Special notes for your reviewer:

Release note:

Removed Windows 2k12 from the available preference
fossedihelm commented 1 month ago

/cc @0xFelix

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-instancetypes/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jcanocan commented 1 month ago

/lgtm

0xFelix commented 1 month ago

/cherry-pick release-1.0

kubevirt-bot commented 1 month ago

@0xFelix: new pull request created: #214

In response to [this](https://github.com/kubevirt/common-instancetypes/pull/213#issuecomment-2250210372): >/cherry-pick release-1.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.