[release-1.0] Revert "Remove Windows 2k12 template"

kubevirt / common-instancetypes

Instancetypes and preferences for running VMs on KubeVirt

https://kubevirt.io/user-guide/virtual_machines/instancetypes/#common-instancetypes

Apache License 2.0

22 stars 15 forks source link

[release-1.0] Revert "Remove Windows 2k12 template" #216

Closed 0xFelix closed 1 month ago

0xFelix commented 1 month ago

What this PR does / why we need it:

This reverts commit 42bdccc936181dde0bf6629ef705634fcef7463c.

This breaking change was merged by accident into an already released version of the common-instancetypes. It should only be part of the 1.2.0 release.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Reverted removal of Windows 2k12 from the available preferences

fossedihelm commented 1 month ago

/lgtm

0xFelix commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-instancetypes/blob/release-1.0/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

ksimon1 commented 1 month ago

@0xFelix do we need to revert this in Common templates too?

fabiand commented 1 month ago

In hte commit or PR message, please provide the reason why this revert is taking place.

0xFelix commented 1 month ago

@fabiand Updated the PR description