search

kubevirt / common-instancetypes

Instancetypes and preferences for running VMs on KubeVirt
https://kubevirt.io/user-guide/virtual_machines/instancetypes/#common-instancetypes
Apache License 2.0
24 stars 17 forks source link

Add instancetype.kubevirt.io/size to all instance types #239

Closed lyarwood closed 2 months ago

lyarwood commented 2 months ago

What this PR does / why we need it:

Some additional metadata to help users search through the available resources in an environment.

This label could also be used by admins when extending or customising common-instancetypes with Kustomize through a labelSelector.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

All instance types now provide a `instancetype.kubevirt.io/size` label denoting the size of the resource as also encoded in the name.
kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-instancetypes/blob/main/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment