search

kubevirt / common-instancetypes

Instancetypes and preferences for running VMs on KubeVirt
https://kubevirt.io/user-guide/virtual_machines/instancetypes/#common-instancetypes
Apache License 2.0
26 stars 17 forks source link

chore: Add flag for setting timeout for creating windows vms #253

Closed ksimon1 closed 1 month ago

ksimon1 commented 2 months ago

What this PR does / why we need it: some Windows images require more time to download image. This commit adds new flag windows-ready-timeout, which will allow user to set higher timeout only for Windows VMs. All other OS distributions will use default timeout.

Release note:

NONE
jcanocan commented 2 months ago

/lgtm

kubevirt-bot commented 1 month ago

Pull requests that are marked with lgtm should receive a review from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

lyarwood commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-instancetypes/blob/main/OWNERS)~~ [lyarwood] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 1 month ago

/remove-label needs-approver-review

lyarwood commented 1 week ago

/cherry-pick release-1.1 /cherry-pick release-1.0

kubevirt-bot commented 1 week ago

@lyarwood: #253 failed to apply on top of branch "release-1.0":

Applying: chore: Add flag for setting timeout for creating windows vms
Using index info to reconstruct a base tree...
M   tests/functests/instancetype_test.go
M   tests/functests/test_suite_test.go
Falling back to patching base and 3-way merge...
Auto-merging tests/functests/test_suite_test.go
CONFLICT (content): Merge conflict in tests/functests/test_suite_test.go
Auto-merging tests/functests/instancetype_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 chore: Add flag for setting timeout for creating windows vms
In response to [this](https://github.com/kubevirt/common-instancetypes/pull/253#issuecomment-2482629659): >/cherry-pick release-1.1 >/cherry-pick release-1.0 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.