kubevirt / common-instancetypes

Instancetypes and preferences for running VMs on KubeVirt
https://kubevirt.io/user-guide/virtual_machines/instancetypes/#common-instancetypes
Apache License 2.0
26 stars 17 forks source link

feat: enable ssh test for windows 2k16 #260

Closed ksimon1 closed 4 weeks ago

ksimon1 commented 1 month ago

What this PR does / why we need it: feat: enable ssh test for windows 2k16

Windows 2k16 image contains working ssh server and the ssh test can be enabled Release note:

NONE
jcanocan commented 4 weeks ago

/lgtm

lyarwood commented 4 weeks ago

/approve

kubevirt-bot commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lyarwood

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-instancetypes/blob/main/OWNERS)~~ [lyarwood] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment