kubevirt / common-templates

Templates for running VMs on KubeVirt
Apache License 2.0
77 stars 63 forks source link

Set architecture to amd64 across all templates #573

Closed lyarwood closed 5 months ago

lyarwood commented 5 months ago

/cc @0xFelix /cc @ksimon1

What this PR does / why we need it:

The current set of templates are only verified on amd64 so to avoid users attempting to run them on aarch64 etc set the architecture within the VirtualMachineInstanceSpec.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

The architecture of each `VirtualMachine` is now  set to `amd64` within the `VirtualMachineInstanceSpec`.
ksimon1 commented 5 months ago

Probably related thread https://groups.google.com/g/kubevirt-dev/c/Fiz0g8cm2_g/m/pFcOAEczAQAJ?utm_medium=email&utm_source=footer

lyarwood commented 5 months ago

/retest-required

fabiand commented 5 months ago

Related to this I still wonder why architecture is a field on the VM spec.

See https://groups.google.com/g/kubevirt-dev/c/Fiz0g8cm2_g And https://github.com/kubevirt/kubevirt/pull/8293#issuecomment-2043288058

lyarwood commented 5 months ago

/retest-required

kubevirt-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-templates/blob/master/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ksimon1 commented 5 months ago

/lgtm