search

kubevirt / common-templates

Templates for running VMs on KubeVirt
Apache License 2.0
77 stars 63 forks source link

fix: Enable networkInterfaceMultiqueue only if sockets > 1 #586

Closed 0xFelix closed 3 months ago

0xFelix commented 3 months ago

What this PR does / why we need it:

Enable networkInterfaceMultiqueue only if the amount of sockets is greater than one, since networkInterfaceMultiqueue requires at least two sockets.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

networkInterfaceMultiqueue is only enabled if the template has more than one socket
ksimon1 commented 3 months ago

/lgtm /approve

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-templates/blob/master/OWNERS)~~ [ksimon1] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
0xFelix commented 3 months ago

/test e2e-gcp-common-templates-centos6

kubevirt-bot commented 3 months ago

@0xFelix: No presubmit jobs available for kubevirt/common-templates@master

In response to [this](https://github.com/kubevirt/common-templates/pull/586#issuecomment-2180770023): >/test e2e-gcp-common-templates-centos6 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
0xFelix commented 3 months ago

/retest-required /cherry-pick release-v0.29

kubevirt-bot commented 3 months ago

@0xFelix: once the present PR merges, I will cherry-pick it on top of release-v0.29 in a new PR and assign it to you.

In response to [this](https://github.com/kubevirt/common-templates/pull/586#issuecomment-2180773032): >/retest-required >/cherry-pick release-v0.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 months ago

@0xFelix: new pull request created: #587

In response to [this](https://github.com/kubevirt/common-templates/pull/586#issuecomment-2180773032): >/retest-required >/cherry-pick release-v0.29 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.