search

kubevirt / common-templates

Templates for running VMs on KubeVirt
Apache License 2.0
77 stars 63 forks source link

fix: add submodule initialization in update-osinfo-db #601

Closed nestoracunablanco closed 1 month ago

nestoracunablanco commented 1 month ago

This change enables the use of 'make update-osinfo-db' without the need for any additional steps.

What this PR does / why we need it: User friendly

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

openshift-ci[bot] commented 1 month ago

Hi @nestoracunablanco. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
ksimon1 commented 1 month ago

/ok-to-test

nestoracunablanco commented 1 month ago

/retest

ksimon1 commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ksimon1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-templates/blob/master/OWNERS)~~ [ksimon1] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment