search

kubevirt / common-templates

Templates for running VMs on KubeVirt
Apache License 2.0
77 stars 63 forks source link

fix: e2e-tests preconditions in makefile #604

Closed nestoracunablanco closed 1 month ago

nestoracunablanco commented 1 month ago

The preconditions for the end-to-end (e2e) tests were previously embedded within the script. This update ensures that unnecessary oc commands are not executed in the event of an error during the generation process.

What this PR does / why we need it: fail faster

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign ksimon1 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/common-templates/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

Hi @nestoracunablanco. Thanks for your PR.

I'm waiting for a kubevirt member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
0xFelix commented 1 month ago

/ok-to-test

nestoracunablanco commented 1 month ago

/retest

jcanocan commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

@nestoracunablanco: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-common-templates-rhel8 7b67a0f533a2e196ec4fc6670bd76575352b2d65 link true /test e2e-gcp-common-templates-rhel8
ci/prow/e2e-gcp-common-templates-fedora 7b67a0f533a2e196ec4fc6670bd76575352b2d65 link true /test e2e-gcp-common-templates-fedora
ci/prow/e2e-gcp-common-templates-windows2016 7b67a0f533a2e196ec4fc6670bd76575352b2d65 link true /test e2e-gcp-common-templates-windows2016
ci/prow/e2e-gcp-common-templates-windows2022 7b67a0f533a2e196ec4fc6670bd76575352b2d65 link true /test e2e-gcp-common-templates-windows2022

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
nestoracunablanco commented 1 month ago

@jcanocan @0xFelix I believe that to enhance the reliability of this script, we should consider adding some wait conditions. However, for now, it seems sufficient for my needs. I will simply drop the PR and revisit later if necessary