search

kubevirt / common-templates

Templates for running VMs on KubeVirt
Apache License 2.0
81 stars 63 forks source link

Windows 11: enable TPM and EFI persistence #611

Closed jean-edouard closed 2 months ago

jean-edouard commented 2 months ago

What this PR does / why we need it: The Windows 11 template enables TPM and EFI, since both a required. However, they were both non-persistent by default, which means bitlocker won't work. Also, in recent versions of Windows 11, bitlocker requires both TPM and EFI to be persistent. This enables persistent EFI and TPM, which requires a RWO FS storage class to be present.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Windows 11 now defaults to persistent TPM and EFI. This requires a storage class capable of ReadWriteMany Filesystem
jcanocan commented 2 months ago

Thanks @ksimon1! /lgtm

0xFelix commented 2 months ago

@jean-edouard Do you want to enable this for Win 2k22 as well? See https://github.com/kubevirt/common-instancetypes/pull/182

acardace commented 2 months ago

can anyone approve this?

0xFelix commented 2 months ago

@acardace What about Win 2k22? For consistency it should be handled the same in common-templates and common-instancetypes.

jean-edouard commented 2 months ago

Right, sorry, adding the change to Win 2k22 now

jcanocan commented 2 months ago

/lgtm

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 0xFelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/common-templates/blob/master/OWNERS)~~ [0xFelix] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jean-edouard commented 2 months ago

/retest

ksimon1 commented 2 months ago

/retest

ksimon1 commented 2 months ago

/retest

ksimon1 commented 2 months ago

@jean-edouard it looks like the win11/2k22 VMs are failing because of this change

ksimon1 commented 2 months ago

/hold

acardace commented 2 months ago

I'd remove win2k22 from this PR, we just need to introduce this for win11, if needed we can open a separate pr for that.

ksimon1 commented 2 months ago

/retest

acardace commented 2 months ago

/retest

ksimon1 commented 2 months ago

/retest

ksimon1 commented 2 months ago

/lgtm

ksimon1 commented 2 months ago

/hold cancel

acardace commented 2 months ago

@jean-edouard @ksimon1 does this need to backported to a release branch to have it in 4.17?

ksimon1 commented 2 months ago

https://github.com/kubevirt/common-templates/releases/tag/v0.30.0 In few minutes it should create new PR to ssp operator, which can be backported to 4.17