kubevirt, sig-buildsystem: add charter and entry in sigs.yaml

dhiller commented 6 months ago

What this PR does / why we need it:

Adds the sig-buildsystem definition and adds the sig to the sigs.yaml

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

/cc @brianmcarey @xpivarc

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

[ ] Design: A design document was considered and is present (link) or not required
[ ] PR: The PR description is expressive enough and will help future contributors
[ ] Code: Write code that humans can understand and Keep it simple
[ ] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[ ] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[ ] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[ ] Documentation: A user-guide update was considered and is present (link) or not required. You want a user-guide update if it's a user facing feature / API change.
[ ] Community: Announcement to kubevirt-dev was considered

Release note:

add sig-buildsystem

kubevirt-bot commented 6 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

dhiller commented 6 months ago

@xpivarc @fabiand thank you for your remarks. I've extended the scope to cover with more concrete things, hope it's better now. PTAL!

aburdenthehand commented 5 months ago

/lgtm

fabiand commented 5 months ago

@dhiller how can we converge aka merge this?

dhiller commented 5 months ago

@dhiller how can we converge aka merge this?

From my POV there are no open issues on this any more. Or are there? @brianmcarey do you see anything that you would like to be changed?

aburdenthehand commented 5 months ago

/approve

kubevirt-bot commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aburdenthehand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/community/blob/main/OWNERS)~~ [aburdenthehand] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubevirt / community

kubevirt, sig-buildsystem: add charter and entry in sigs.yaml #272