Design Proposal: Provide way to customize generated Multus pod annotation

chomatdam commented 3 months ago

What this PR does / why we need it: When virt-controller is generating the Multus pod annotation, several properties can be set:

name
namespace
interface
mac (optional)

This proposal enables the customization of the Multus annotation.

Implementation

kubevirt/kubevirt/pull/10923

Documentation

kubevirt/user-guide/pull/749

Which issue(s) this PR fixes: Fixes #4564

Checklist

[x] Design: A design document was considered and is present (link) or not required
[x] PR: The PR description is expressive enough and will help future contributors
[x] Code: Write code that humans can understand and Keep it simple
[x] Refactor: You have left the code cleaner than you found it (Boy Scout Rule)
[x] Upgrade: Impact of this change on upgrade flows was considered and addressed if required
[x] Testing: New code requires new unit tests. New features and bug fixes require at least on e2e test
[x] Documentation: A user-guide update was considered and is present (https://github.com/kubevirt/user-guide/pull/749).
[x] Community: Announcement to kubevirt-dev (Slack Message)

Release note:

Add a way to customize generated Multus pod annotation using mutating webhook

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign vladikr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/community/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

kubevirt-bot commented 3 months ago

Hi @chomatdam. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

EdDev commented 3 months ago

/cc

EdDev commented 3 months ago

/sig network

EdDev commented 3 months ago

/cc @AlonaKaplan

EdDev commented 3 months ago

/sig api

kubevirt-bot commented 1 day ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

kubevirt / community

Design Proposal: Provide way to customize generated Multus pod annotation #275