Closed maiqueb closed 5 months ago
/assign @AlonaKaplan
/cc
/sig network
Thank you for posting this interesting proposal.
In addition to the review comments, I was thinking about trying to propose an alternative that decouples Kubevirt from the IPClaim in both directions.
I'm not sure if it is best to discuss it in a thread here, but it can be a good initial start.
It is in the spirit of IPClaim having its own controller, but not being dependent on Kubevirt directly. I will try to write something early next week or update back if I fail.
I honestly don't see how that is possible without traversing the pod's owner reference tree upward until its root using unstructured ... which is ... very ugly. That was the only "generic" way I can think of tying the IPAMClaim to an arbitrary resource type that would own it.
I prefer to go for something simple, straight-forward, and easy to reason about for the one use case we have in front of us instead of going for the gold and try to envision workload types we have no requirements for (and don't even know what they might be).
But be my guest - try to come up with something.
Thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AlonaKaplan
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Thanks !
/lgtm
What this PR does / why we need it: This PR adds a design document outlining how to integrate the persistent IPs feature of the kubernetes multi-networking de-facto standard into KubeVirt.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: