Closed lyarwood closed 2 months ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign rmohr for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@lyarwood: Closed this PR.
What this PR does / why we need it:
At present users of the
instancetype.kubevirt.io/v1beta1
API and CRDs are able to define a CPU topology for aVirtualMachine
through a combination of vCPUs provided by theguest
attribute of an instance type and an optional topology provided by thepreferredCPUTopology
attribute of a preference.This design proposal aims to extend the API to allow for an optional guest CPU topology to be provided by a referenced instance type instead of a generic number of vCPUs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
This PR also introduces a dedicated
instancetype.kubevirt.io
directory for design proposals related to the API and CRDs.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: