kubevirt / community

Community content
https://kubevirt.io
46 stars 101 forks source link

Network binding plugin: Support resource overhead #303

Open orelmisan opened 2 weeks ago

orelmisan commented 2 weeks ago

What this PR does / why we need it: Currently, on most cases, the network binding plugin sidecar container is specified without resource requests/limits. Suggest several alternatives to address this issue.

Additionally, some network binding plugins require a binary to be executed in the compute container, for example the passt plugin. Suggest several alternatives to address this issue.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.

Release note:

NONE
kubevirt-bot commented 2 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

kubevirt-bot commented 2 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/community/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
orelmisan commented 2 weeks ago

/cc @EdDev @ormergi

orelmisan commented 2 weeks ago

/uncc @aburdenthehand @jobbler

orelmisan commented 1 week ago

Change: Removed the passt example, as it is not essential for to the proposal.

Addressed sidecar and compute container resource specification.

orelmisan commented 1 week ago

@EdDev @ormergi PTAL.

orelmisan commented 1 week ago

Change: Answered review comment.

orelmisan commented 1 day ago

Change: Moved the API alternative to be the proposed solution.

aburdenthehand commented 4 hours ago

/cc @stu-gott - needs review from someone in sig-compute. Thanks!