Open orelmisan opened 2 weeks ago
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign alonakaplan for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
/cc @EdDev @ormergi
/uncc @aburdenthehand @jobbler
Change: Removed the passt example, as it is not essential for to the proposal.
Addressed sidecar and compute container resource specification.
@EdDev @ormergi PTAL.
/cc @stu-gott - needs review from someone in sig-compute. Thanks!
What this PR does / why we need it: Currently, on most cases, the network binding plugin sidecar container is specified without resource requests/limits. Suggest several alternatives to address this issue.
Additionally, some network binding plugins require a binary to be executed in the compute container, for example the passt plugin. Suggest several alternatives to address this issue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #Special notes for your reviewer:
Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR. Approvers are expected to review this list.
Release note: