kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
395 stars 249 forks source link

Improve test resilience by wrapping updates around eventually statements #3291

Closed alromeros closed 1 month ago

alromeros commented 1 month ago

What this PR does / why we need it:

This Pull Request aims to improve test resilience by wrapping PVC, PV and DataVolume updates inside eventually statements.

I haven't wrapped other object's Updates (such as CDI CRs or Storage profiles) since these will hardly fail with the "object has been modified" error.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes # https://issues.redhat.com/browse/CNV-40014

Release note:

NONE
coveralls commented 1 month ago

Coverage Status

coverage: 59.038% (+0.02%) from 59.016% when pulling 7f935fd9917bc52c400da8159d84d174f1b35928 on alromeros:make-tests-resilient-to-updates into 073336b16cda8c3a605c8e702c69008a01210264 on kubevirt:main.

alromeros commented 1 month ago

/retest-required

alromeros commented 1 month ago

/retest-required

alromeros commented 1 month ago

/test pull-containerized-data-importer-e2e-ceph-wffc

EduardGomezEscandell commented 1 month ago

/lgtm

alromeros commented 1 month ago

/cc @akalenyu

alromeros commented 1 month ago

/retest-required

alromeros commented 1 month ago

/retest-required

alromeros commented 1 month ago

/retest-required

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [akalenyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alromeros commented 1 month ago

/test pull-containerized-data-importer-e2e-nfs

EduardGomezEscandell commented 1 month ago

/lgtm