search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

Fix progress reporting for http imports #3293

Closed akalenyu closed 3 months ago

akalenyu commented 4 months ago

What this PR does / why we need it: Progress reporting has been disabled across the board for a while since we stop using nbdkit/direct raw imports. This PR fixes the issue alongside a flawed test case that was supposed to catch this regression.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Fix progress reporting for http imports
coveralls commented 4 months ago

Coverage Status

coverage: 58.926% (+0.008%) from 58.918% when pulling d949f6a2f5fbe00f4ed326d356ac08c1260f3e13 on akalenyu:fix-progress-test into d365661e305bc67cb753cd963549b89b8a1f01e2 on kubevirt:main.

akalenyu commented 4 months ago

/cc @arnongilboa @alromeros

akalenyu commented 4 months ago

/hold cancel

akalenyu commented 4 months ago

/retest

awels commented 3 months ago

/lgtm /approve

kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [awels] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
awels commented 3 months ago

/test pull-containerized-data-importer-non-csi-hpp

akalenyu commented 3 months ago

/cherrypick release-v1.58

kubevirt-bot commented 3 months ago

@akalenyu: #3293 failed to apply on top of branch "release-v1.58":

Applying: tests: fix regex in import progress test
Applying: Fix actual progress reporting for url->scratch
Using index info to reconstruct a base tree...
M   pkg/importer/http-datasource.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/importer/http-datasource.go
CONFLICT (content): Merge conflict in pkg/importer/http-datasource.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 Fix actual progress reporting for url->scratch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3293#issuecomment-2171754301): >/cherrypick release-v1.58 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jpeimer commented 2 months ago

/cherrypick release-v1.60

kubevirt-bot commented 2 months ago

@jpeimer: only kubevirt org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3293#issuecomment-2250501711): >/cherrypick release-v1.60 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jpeimer commented 2 months ago

Oh, we actually don't have 1.60 yet