Add tests AfterEach nil checks

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.

Apache License 2.0

395 stars 249 forks source link

Add tests AfterEach nil checks #3294

Closed arnongilboa closed 1 month ago

arnongilboa commented 1 month ago

What this PR does / why we need it: CI lanes have lots of panicks in AfterEach.

Which issue(s) this PR fixes: Fixes #

Special notes for your reviewer:

Release note:

NONE

coveralls commented 1 month ago

coverage: 58.521% (+0.03%) from 58.496% when pulling 83345cf0ceeb874f16fe6a987774ed93c378e68a on arnongilboa:add_aftereach_nil_checks into 9a965239012287d324caf71a08d35f0febf551ff on kubevirt:main.

arnongilboa commented 1 month ago

/hold

There are some more AftterEach panicks to be fixed

ShellyKa13 commented 1 month ago

/lgtm hopefully now you got it all :) nice catch! btw not sure what is up with the sonarcloud security hotspots

arnongilboa commented 1 month ago

/unhold

arnongilboa commented 1 month ago

/retest

ShellyKa13 commented 1 month ago

/lgtm

akalenyu commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [akalenyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment