search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
395 stars 249 forks source link

Revert LVMO storage CSI snapshot clone. #3303

Closed awels closed 1 month ago

awels commented 1 month ago

What this PR does / why we need it: On multi node LMVO this setting can cause issues so reverting to host assisted clone which works everywhere Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
akalenyu commented 1 month ago

/lgtm /cc @mhenriks

coveralls commented 1 month ago

Coverage Status

coverage: 59.082% (+0.07%) from 59.016% when pulling b231e314093387bc729d08fa6713eeeac17cf81b on awels:revert_lvmo_clone into 073336b16cda8c3a605c8e702c69008a01210264 on kubevirt:main.

awels commented 1 month ago

/test pull-containerized-data-importer-e2e-upg

akalenyu commented 1 month ago

/hold could you please also revert golden snapshot sources? otherwise, it'll attempt restores from snapshot https://github.com/kubevirt/containerized-data-importer/pull/3196/files#diff-a21d708ef3a53b6344a19726606fc760e43ce13f1927330084763c6f584196f2R114-R115

awels commented 1 month ago

Done, completely missed that.

akalenyu commented 1 month ago

Done, completely missed that.

Me too..

akalenyu commented 1 month ago

/lgtm

akalenyu commented 1 month ago

/hold cancel

awels commented 1 month ago

/test pull-cdi-goveralls

mhenriks commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
awels commented 1 month ago

/cherrypick release-v1.59

kubevirt-bot commented 1 month ago

@awels: #3303 failed to apply on top of branch "release-v1.59":

Applying: Revert LVMO storage CSI snapshot clone.
Using index info to reconstruct a base tree...
M   pkg/storagecapabilities/storagecapabilities.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/storagecapabilities/storagecapabilities.go
CONFLICT (content): Merge conflict in pkg/storagecapabilities/storagecapabilities.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Revert LVMO storage CSI snapshot clone.
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3303#issuecomment-2148056158): >/cherrypick release-v1.59 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
jpeimer commented 1 month ago

/cherrypick release-v1.58

kubevirt-bot commented 1 month ago

@jpeimer: only kubevirt org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3303#issuecomment-2165828931): >/cherrypick release-v1.58 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akalenyu commented 1 month ago

/cherrypick release-v1.58

kubevirt-bot commented 1 month ago

@akalenyu: new pull request created: #3319

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3303#issuecomment-2165895478): >/cherrypick release-v1.58 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.