kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

[release-v1.59] manual backport of 'forklift: rename API group' #3305

Closed bennyz closed 4 months ago

bennyz commented 4 months ago

What this PR does / why we need it:

Since forklift 2.7 has to support OCP 4.15 we'll have 2 competing controllers, this PR changes the API group for CDI's so forklift can distinguish between them.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Rename API group for forklift controllers to forklift.cdi.kubevirt.io
kubevirt-bot commented 4 months ago

Hi @bennyz. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akalenyu commented 4 months ago

/test all

akalenyu commented 4 months ago

/approve /lgtm https://issues.redhat.com/browse/CNV-42363

kubevirt-bot commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/release-v1.59/OWNERS)~~ [akalenyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akalenyu commented 4 months ago

/test pull-containerized-data-importer-e2e-hpp-previous