search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
395 stars 249 forks source link

Suppress CDIDefaultStorageClassDegraded on SNO #3310

Closed arnongilboa closed 1 month ago

arnongilboa commented 1 month ago

What this PR does / why we need it: On single-node OpenShift, even if none of the default/virt default storage classes supports ReadWriteMany (but supports smart clone), we will not fire the CDIDefaultStorageClassDegraded alert. We added degraded label to kubevirt_cdi_storageprofile_info to simplify the alert expression.

Which issue(s) this PR fixes: jira-ticket: https://issues.redhat.com/browse/CNV-40665

Special notes for your reviewer:

Release note:

Suppress CDIDefaultStorageClassDegraded alert on SNO
coveralls commented 1 month ago

Coverage Status

coverage: 59.075% (+0.05%) from 59.023% when pulling 3d99cfbd34af7659ca285c7d22b73662609c9c1d on arnongilboa:suppress_alerts_on_sno into f3d00603532a18005e80d00ef6b6373bb128688f on kubevirt:main.

akalenyu commented 1 month ago

/approve /hold unhold once you're happy with https://github.com/kubevirt/containerized-data-importer/pull/3310#discussion_r1641869644

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [akalenyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
arnongilboa commented 1 month ago

/unhold

coveralls commented 1 month ago

Coverage Status

coverage: 59.056% (+0.03%) from 59.023% when pulling 45a28d6dc29ac39b90c329c8b23a5ce9c1f87e68 on arnongilboa:suppress_alerts_on_sno into f3d00603532a18005e80d00ef6b6373bb128688f on kubevirt:main.

akalenyu commented 1 month ago

/lgtm

akalenyu commented 1 month ago

@arnongilboa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command pull-containerized-data-importer-e2e-nfs 45a28d6 link true /test pull-containerized-data-importer-e2e-nfs

@arnongilboa I think this is a real bug, the "Error" condition reason will not appear anymore after https://github.com/kubevirt/containerized-data-importer/pull/3194

arnongilboa commented 1 month ago

/retest

arnongilboa commented 1 month ago

@arnongilboa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command pull-containerized-data-importer-e2e-nfs 45a28d6 link true /test pull-containerized-data-importer-e2e-nfs

@arnongilboa I think this is a real bug, the "Error" condition reason will not appear anymore after #3194

Shouldn't it fail on all PRs? it has nothing to do with this one and should be fixed separately.

akalenyu commented 1 month ago

@arnongilboa: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests: Test name Commit Details Required Rerun command pull-containerized-data-importer-e2e-nfs 45a28d6 link true /test pull-containerized-data-importer-e2e-nfs

@arnongilboa I think this is a real bug, the "Error" condition reason will not appear anymore after #3194

Shouldn't it fail on all PRs? it has nothing to do with this one and should be fixed separately.

Maybe there's something wrong with the test? It's not related to this PR and should have started failing since that change

arnongilboa commented 1 month ago

/cherrypick release-v1.59

kubevirt-bot commented 1 month ago

@arnongilboa: new pull request created: #3327

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3310#issuecomment-2175241205): >/cherrypick release-v1.59 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
arnongilboa commented 1 month ago

/cherrypick release-v1.58

kubevirt-bot commented 1 month ago

@arnongilboa: #3310 failed to apply on top of branch "release-v1.58":

Applying: Suppress CDIDefaultStorageClassDegraded on SNO
Using index info to reconstruct a base tree...
M   doc/metrics.md
M   pkg/controller/storageprofile-controller.go
M   pkg/controller/storageprofile-controller_test.go
A   pkg/monitoring/metrics/cdi-controller/storageprofile.go
A   pkg/monitoring/rules/alerts/operator.go
M   pkg/operator/resources/cluster/controller.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/operator/resources/cluster/controller.go
CONFLICT (modify/delete): pkg/monitoring/rules/alerts/operator.go deleted in HEAD and modified in Suppress CDIDefaultStorageClassDegraded on SNO. Version Suppress CDIDefaultStorageClassDegraded on SNO of pkg/monitoring/rules/alerts/operator.go left in tree.
CONFLICT (modify/delete): pkg/monitoring/metrics/cdi-controller/storageprofile.go deleted in HEAD and modified in Suppress CDIDefaultStorageClassDegraded on SNO. Version Suppress CDIDefaultStorageClassDegraded on SNO of pkg/monitoring/metrics/cdi-controller/storageprofile.go left in tree.
Auto-merging pkg/controller/storageprofile-controller_test.go
CONFLICT (content): Merge conflict in pkg/controller/storageprofile-controller_test.go
Auto-merging pkg/controller/storageprofile-controller.go
CONFLICT (content): Merge conflict in pkg/controller/storageprofile-controller.go
Auto-merging doc/metrics.md
CONFLICT (content): Merge conflict in doc/metrics.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Suppress CDIDefaultStorageClassDegraded on SNO
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3310#issuecomment-2175337490): >/cherrypick release-v1.58 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.