search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
395 stars 249 forks source link

State explicit go version in go.mod files #3311

Closed akalenyu closed 1 month ago

akalenyu commented 1 month ago

What this PR does / why we need it: This is needed when building CDI on different platforms, and it looks like this is the common practice nowadays as well.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
akalenyu commented 1 month ago

/cc @dominikholler @enp0s3 @phoracek This may be of interest to you in the respective kubevirt projects

ShellyKa13 commented 1 month ago

/lgtm

akalenyu commented 1 month ago

/retest

akalenyu commented 1 month ago

/test pull-cdi-goveralls

coveralls commented 1 month ago

Coverage Status

coverage: 59.049% (+0.03%) from 59.023% when pulling b070ba313c705aec134ec87c001bb753ef71df5c on akalenyu:explicit-go-patch-ver into f3d00603532a18005e80d00ef6b6373bb128688f on kubevirt:main.

awels commented 1 month ago

/approve

kubevirt-bot commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: awels

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [awels] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment