search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

fix: Make valid labels regex less restrictive #3317

Closed 0xFelix closed 3 months ago

0xFelix commented 3 months ago

What this PR does / why we need it:

This makes the valid labels regex that is used to restrict labels that are transferred from a prime PVC to an actual PVC less restrictive, so labels like 'instancetype.kubevirt.io/default-preference' are transferred too.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #3315

Special notes for your reviewer:

Release note:

fix: Properly transfer instancetype labels during containerdisk imports
0xFelix commented 3 months ago

/cherry-pick release-v1.59

kubevirt-bot commented 3 months ago

@0xFelix: once the present PR merges, I will cherry-pick it on top of release-v1.59 in a new PR and assign it to you.

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3317#issuecomment-2165062930): >/cherry-pick release-v1.59 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [akalenyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akalenyu commented 3 months ago

/test pull-cdi-goveralls

akalenyu commented 3 months ago

/test pull-cdi-goveralls

Wow the goveralls lane tends to flake over cert rotation tests pretty frequently

kubevirt-bot commented 3 months ago

@0xFelix: new pull request created: #3318

In response to [this](https://github.com/kubevirt/containerized-data-importer/pull/3317#issuecomment-2165062930): >/cherry-pick release-v1.59 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.