search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

forklift: add missing rbac #3320

Open bennyz opened 3 months ago

bennyz commented 3 months ago

What this PR does / why we need it:

Add missing RBAC for ovirt and openstack volume populator CRDs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

Add missing RBAC for ovirt and openstack volume populator CRDs
kubevirt-bot commented 3 months ago

Hi @bennyz. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
kubevirt-bot commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign akalenyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akalenyu commented 3 months ago

/test all

I remember having global perms was not recommended

Yup, there should be a unit test for this EDIT: We have exceptions for some global permissions. For example, it would make sense that "CDI can do anything on CDI resources", maybe the same applies to these resources as well, have to check

awels commented 2 months ago

/test all

awels commented 1 month ago

/retest

kubevirt-bot commented 1 month ago

@bennyz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cdi-goveralls e0b0dc20dab0e52048fe24fcd30ed0d4dc455895 link false /test pull-cdi-goveralls
pull-cdi-unit-test e0b0dc20dab0e52048fe24fcd30ed0d4dc455895 link false /test pull-cdi-unit-test
Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).