search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
395 stars 249 forks source link

[release-v1.59] Add vSphere storagecapabilities #3328

Open ido106 opened 3 weeks ago

ido106 commented 3 weeks ago

What this PR does / why we need it: Manual backport of #3284

Adding storagecapabilities to vSphere provisioner.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): jira-ticket: https://issues.redhat.com/browse/CNV-43281

Special notes for your reviewer:

Release note:

Add storagecapabilities to vSphere provisioner
kubevirt-bot commented 3 weeks ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign awels for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/release-v1.59/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
kubevirt-bot commented 3 weeks ago

Hi @ido106. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akalenyu commented 3 weeks ago

/hold until we're ready to merge into this release branch

q: do we maybe want to gather more storagecapabilities in a single PR?

ido106 commented 3 weeks ago

I can add them all at once, once they merge I also have to backport to CNV v4.12.0, CNV v4.13.0, CNV v4.14.0, CNV v4.15.0

kubevirt-bot commented 1 week ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
akalenyu commented 1 week ago

/hold until we're ready to merge into this release branch

q: do we maybe want to gather more storagecapabilities in a single PR?

https://github.com/kubevirt/containerized-data-importer/pull/3345