search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

Fix qemu O_DIRECT refusing unit tests #3333

Closed akalenyu closed 2 months ago

akalenyu commented 3 months ago

What this PR does / why we need it: These tests relied on tmpfs not supporting direct IO, but that has changed recently with https://github.com/torvalds/linux/commit/e88e0d366f9cfbb810b0c8509dc5d130d5a53e02. Refactored the direct IO utils in a way that allows testing without real filesystems.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #

Special notes for your reviewer:

Release note:

NONE
akalenyu commented 3 months ago

/cc @alromeros @mhenriks

akalenyu commented 3 months ago

/test pull-containerized-data-importer-e2e-istio

mhenriks commented 2 months ago

/lgtm /approve

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mhenriks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [mhenriks] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
akalenyu commented 2 months ago

/test pull-containerized-data-importer-e2e-upg

akalenyu commented 2 months ago

@akalenyu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command pull-containerized-data-importer-e2e-hpp-latest deb6d08 link unknown /test pull-containerized-data-importer-e2e-hpp-latest

this is not good lol

                "phase": "ImportScheduled",
                "progress": "100.0%",

on the source-dv

/test pull-containerized-data-importer-e2e-hpp-latest