search

kubevirt / containerized-data-importer

Data Import Service for kubernetes, designed with kubevirt in mind.
Apache License 2.0
413 stars 259 forks source link

update to k8s 1.30 libs and controller-runtime 0.18.4 #3336

Closed mhenriks closed 2 months ago

mhenriks commented 3 months ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1097

Special notes for your reviewer:

Release note:

k8s 1.30 libs and controller-runtime 0.18.4
akalenyu commented 3 months ago

/retest

akalenyu commented 3 months ago

@awels I think something's up with FOSSA here

mhenriks commented 2 months ago

/unhold

akalenyu commented 2 months ago

/approve /cc @awels FOSSA is lying I think

kubevirt-bot commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akalenyu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/kubevirt/containerized-data-importer/blob/main/OWNERS)~~ [akalenyu] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
awels commented 2 months ago

Hmmm so it is complaining about a dependency in vendor/github.com/hashicorp/golang-lru being MPL 2.0. Which is not compatible with our licenses. It is being vendor-ed in through github.com/openshift/library-go I think we should avoid anything hashicorp as much as possible.

akalenyu commented 2 months ago

Hmmm so it is complaining about a depedency in vendor/github.com/hashicorp/golang-lru being MPL 2.0. Which is not compatible with our licenses. It is being vendor-ed in through github.com/openshift/library-go I think we should avoid anything hashicorp as much as possible.

right.. I see it's coming from their dep. on distribution/distribution in helpers we are not using: https://github.com/openshift/library-go/pull/1529/commits/01526ee81bea21c8cb6741d34c2dbbe10ae8aa8d anyway, I wonder how other library-go consumers are not finding this problem

mhenriks commented 2 months ago

@awels golang-lru code is not in vendor directory so we are not actually directly or indirectly using it. Are there exceptions for this?

awels commented 2 months ago

I can mark it as an exception indicating it is not being used at all. I wonder why it was flagged. You are right that it is not being vendored at all.

awels commented 2 months ago

/test pull-containerized-data-importer-fossa

awels commented 2 months ago

/test pull-containerized-data-importer-fossa

awels commented 2 months ago

/lgtm

akalenyu commented 2 months ago

/test pull-containerized-data-importer-e2e-upg

akalenyu commented 2 months ago

I think this failure is about doing a rebind when pod is still running? "cdi.kubevirt.io/storage.pod.phase": "Running", https://prow.ci.kubevirt.io/view/gs/kubevirt-prow/pr-logs/pull/kubevirt_containerized-data-importer/3336/pull-containerized-data-importer-e2e-upg/1811766743761162240

akalenyu commented 2 months ago

/test pull-containerized-data-importer-e2e-nfs Error: failed get datavolume: test-dv, client rate limiter Wait returned an error: context deadline exceeded